My boys (9 and 12) are nuts about collecting Pokémon cards. They have no real interest in coins, but they fully grasp the collecting passion. I suspect that passion is part of the human condition, affects a small minority more than most - and perhaps men more than women.
I don’t think money evolving from gold to coins to cheques to credit cards to something else will have any impact at all. I don’t think the association between money and what we collect is relevant - unless you collect the coins of your youth. I collect mainly Victorian.
I expect premium tangible artifacts from pre-digital times will only become more sought after as the world becomes evermore virtual - and as networks evolve to better connect sellers and buyers. In this context (short term bubbles apart) coins are well placed for a host of reasons: scarcity, size, prettiness, durability, sophistication of the numismatic art.
I also think numismatics will benefit from the inevitable end of woke historical revisionism, once it has run its course - as many societies go through cycles of embracing or rejecting their history. (Perhaps numismatics are already beneficiaries as a refuge to that.) I don’t see woke revisionism lasting in my kids’ generation. They and their friends seem as mythed by it as me. A renaissance may be due …